Skip to content

🌐 Add Portuguese translation for docs/pt/docs/advanced/generate-clients.md#13030

Merged
alejsdev merged 6 commits into
fastapi:masterfrom
vitumenezes:docs/advanced/generate-clients
Dec 12, 2024
Merged

🌐 Add Portuguese translation for docs/pt/docs/advanced/generate-clients.md#13030
alejsdev merged 6 commits into
fastapi:masterfrom
vitumenezes:docs/advanced/generate-clients

Conversation

@vitumenezes

Copy link
Copy Markdown
Contributor

I had some difficulty translating sentences that used the term "payload", especially on line 252.

@github-actions github-actions Bot added the lang-all Translations label Dec 4, 2024
@github-actions

github-actions Bot commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

@alejsdev alejsdev added lang-pt Portuguese translations awaiting-review labels Dec 9, 2024

@nazarepiedady nazarepiedady left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good enough to be considered.

@ceb10n ceb10n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @vitumenezes

Just a minor problem in the translation of the admonition.

🚀


<img src="/img/tutorial/generate-clients/image03.png">

/// Dica

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't translate the admonitions directly.

The right way to translate it is to keep the admonition, and then add a pipe + the translation.

You can check the docs for this at: Translation specific tips and guidelines

So, it would be:

/// tip | Dica
...
///

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! I'll fix it. Thanks 🫂

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not with my pc to test it right now, but the t in tip is lowercase. I don't know if it will work with a capital letter

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eeeerrr, lack of attention 🤦🏼. will fix it!

@vitumenezes vitumenezes requested a review from ceb10n December 10, 2024 20:24
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@ceb10n ceb10n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect @vitumenezes

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@alejsdev alejsdev merged commit a277942 into fastapi:master Dec 12, 2024
@alejsdev

Copy link
Copy Markdown
Member

Thanks for your contribution! @vitumenezes 🤓
And thanks for the review @ceb10n 🔍

@vitumenezes vitumenezes deleted the docs/advanced/generate-clients branch December 16, 2024 23:04
s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-pt Portuguese translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants