Skip to content

🩺 Unify the badges across all tutorial translations#13329

Merged
tiangolo merged 9 commits into
fastapi:masterfrom
svlandeg:fix/badge
Feb 20, 2025
Merged

🩺 Unify the badges across all tutorial translations#13329
tiangolo merged 9 commits into
fastapi:masterfrom
svlandeg:fix/badge

Conversation

@svlandeg

@svlandeg svlandeg commented Feb 6, 2025

Copy link
Copy Markdown
Member

Currently, the displayed badges can be quite different between translations, even potentially showing a different status, like is the case right now: https://fastapi.tiangolo.com/ vs. https://fastapi.tiangolo.com/bn/

image

image

This PR ensures consistency of the displayed badges:

  • Using only pushes to master to determine the status of the Test badge
  • Use the new format as introduced in 📝 Fix test badge #13313 for all languages
  • Using coverage-badge.samuelcolvin.workers.dev for the Coverage badge
  • Including a badge for the supported Python versions on all pages.

@github-actions github-actions Bot added the lang-all Translations label Feb 6, 2025
@svlandeg

svlandeg commented Feb 6, 2025

Copy link
Copy Markdown
Member Author

Note that currently, the Test badge displayes "no status" which seems wrong as the runs are all green. While we probably need to investigate that, too, I don't think it's directly relevant to this PR, which simply unifies everything.

[UPDATE:] This should now be fixed

@svlandeg svlandeg added docs Documentation about how to use FastAPI and removed lang-all Translations labels Feb 6, 2025

@svlandeg svlandeg left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since submitting this PR, the coverage badge seems to be broken on master as well;

image

Again - I don't think this is related to this PR in particular, it seems like a wider problem.

[UPDATE:] This should now be fixed

@alv2017

alv2017 commented Feb 8, 2025

Copy link
Copy Markdown
Contributor

I would suggest to fix the English version first. 🛠️
(Currently on the main website Test and coverage badges are not working)

This PR #13313 fixes the Test badge.

(... and I expect that as soon as you merge it, the coverage badge will be fixed as well) 😄

@svlandeg svlandeg mentioned this pull request Feb 10, 2025
@svlandeg svlandeg marked this pull request as draft February 10, 2025 11:22
@github-actions github-actions Bot added the lang-all Translations label Feb 10, 2025
@svlandeg svlandeg removed the lang-all Translations label Feb 10, 2025
@svlandeg svlandeg self-assigned this Feb 10, 2025
@github-actions github-actions Bot added the lang-all Translations label Feb 10, 2025
@svlandeg svlandeg removed the lang-all Translations label Feb 10, 2025
@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit d920c71 at: https://861f0d77.fastapitiangolo.pages.dev

Modified Pages

@github-actions github-actions Bot added the lang-all Translations label Feb 10, 2025
@svlandeg svlandeg removed the lang-all Translations label Feb 10, 2025
@svlandeg svlandeg marked this pull request as ready for review February 10, 2025 11:45
@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit a662089 at: https://7377c77a.fastapitiangolo.pages.dev

Modified Pages

@alv2017

alv2017 commented Feb 10, 2025

Copy link
Copy Markdown
Contributor

@svlandeg

Applied fixes looks good. 😃

Missing fixes:

  • it
  • ja

@github-actions github-actions Bot added the lang-all Translations label Feb 10, 2025
@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 76767c2 at: https://05bf7097.fastapitiangolo.pages.dev

Modified Pages

@svlandeg svlandeg removed the lang-all Translations label Feb 10, 2025
@github-actions github-actions Bot added the lang-all Translations label Feb 15, 2025
@github-actions

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit de8d4f2 at: https://37c09c5e.fastapitiangolo.pages.dev

Modified Pages

@alejsdev alejsdev removed the lang-all Translations label Feb 15, 2025
@svlandeg svlandeg removed their assignment Feb 18, 2025

@tiangolo tiangolo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! 🚀

@tiangolo tiangolo merged commit f8878f3 into fastapi:master Feb 20, 2025
@svlandeg svlandeg deleted the fix/badge branch February 21, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation about how to use FastAPI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants