✅ Enable test case for duplicated headers in test_tutorial/test_header_params/test_tutorial003.py#13864
Merged
tiangolo merged 3 commits intoSep 20, 2025
Conversation
…include multiple `x-token` values
Contributor
Author
|
Hi, I see the PR is failing because of a missing label. I don’t have permission to add it — can someone from the team help with that? Thank you!” |
Thanks for this PR. For reference, you might want to include relevant links next time https://www.rfc-editor.org/rfc/rfc9110.html#section-5.3-1 |
test_tutorial003.pytest_tutorial003.py
test_tutorial003.pytest_tutorial003.py
test_tutorial003.pytest_tutorial/test_header_params/test_tutorial003.py
YuriiMotov
approved these changes
Jul 6, 2025
YuriiMotov
left a comment
Member
There was a problem hiding this comment.
This test case covers the use-case described in docs: Duplicate headers.
Don't see anything wrong in enabling it
isgin01
approved these changes
Jul 7, 2025
tiangolo
approved these changes
Sep 20, 2025
tiangolo
left a comment
Member
There was a problem hiding this comment.
This was probably failing at some point 🤔 Thanks! ☕
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test coverage for multiple header values in TestClient
Summary
This PR adds test coverage for multiple header values passed as a list of tuples to FastAPI's TestClient, resolving a long-standing TODO comment in the test suite.
Background
The test file tests/test_tutorial/test_header_params/test_tutorial003.py contained a commented-out test case with a TODO comment questioning whether multiple header values were working correctly:
Technical Details
When multiple headers with the same name are passed as a list of tuples like [("x-token", "foo"), ("x-token", "bar")], FastAPI correctly processes them as a list of values ["foo", "bar"]. This is the expected HTTP behavior for multiple headers with the same name.
Type of Change:
Checklist: