Read field_info per body param instead of assuming it to be all equal.#9410
Read field_info per body param instead of assuming it to be all equal.#9410jsg921019 wants to merge 2 commits into
Conversation
|
📝 Docs preview for commit 6185a92 at: https://643fe0d2fa9fcc0df5f30784--fastapi.netlify.app |
|
📝 Docs preview for commit 38ac252 at: https://643fe3243ab0c51023852f41--fastapi.netlify.app |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
YuriiMotov
left a comment
There was a problem hiding this comment.
After applying changes I mentioned I will be ready to approve this PR
| def test_post_form_no_body(): | ||
| response = client.post("/files/") | ||
| assert response.status_code == 422, response.text | ||
| assert response.json() == file_and_token_required |
There was a problem hiding this comment.
This fails in current version of Pydantic.
Error message format was changed.
I world suggest removing this line (and in other tests with response.status_code == 422)
| client = TestClient(app) | ||
|
|
||
| openapi_schema = { | ||
| "openapi": "3.0.2", |
There was a problem hiding this comment.
| "openapi": "3.0.2", | |
| "openapi": "3.1.0", |
Current version is 3.1.0
|
@jsg921019 I took the liberty to resubmit your fix in #11194 so that it includes the latest FastAPI changes |
|
As this PR has been waiting for the original user for a while but seems to be inactive, it's now going to be closed. But if there's anyone interested, feel free to create a new PR. |
|
@jsg921019, sorry, it was closed automatically. |
fixes #9116