Skip to content

fix: Resolve module on windows#4827

Merged
franciscojavierarceo merged 2 commits into
feast-dev:masterfrom
nanshakov:patch-1
Feb 9, 2025
Merged

fix: Resolve module on windows#4827
franciscojavierarceo merged 2 commits into
feast-dev:masterfrom
nanshakov:patch-1

Conversation

@nanshakov

@nanshakov nanshakov commented Dec 10, 2024

Copy link
Copy Markdown
Contributor

Fix resolve module on windows.

What this PR does / why we need it:

Fix resolve module on Windows platform by replace \\ to .
Repo example struct
G:.
│ .feastignore
│ feature_store.yaml

├───entities
│ entities.py
init.py

├───features
│ │ init.py
│ │

Which issue(s) this PR fixes:

File "", line 991, in _find_and_load
File "", line 973, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'entities\\entities'

Misc

@nanshakov nanshakov requested a review from a team as a code owner December 10, 2024 11:16
@nanshakov nanshakov changed the title Fix resolve module on windows fix: resolve module on windows Dec 10, 2024
nanshakov and others added 2 commits February 5, 2025 22:49
fix resolve module on windows

Signed-off-by: Nik <Anshakov>
@nanshakov

Copy link
Copy Markdown
Contributor Author

@franciscojavierarceo could you please approve

@franciscojavierarceo franciscojavierarceo changed the title fix: resolve module on windows fix: Resolve module on windows Feb 7, 2025
@franciscojavierarceo franciscojavierarceo merged commit efbffa4 into feast-dev:master Feb 9, 2025
franciscojavierarceo pushed a commit that referenced this pull request Feb 17, 2025
# [0.46.0](v0.45.0...v0.46.0) (2025-02-17)

### Bug Fixes

* Add scylladb to online stores list in docs ([#5061](#5061)) ([08183ed](08183ed))
* Changed feast operator to set status of featurestore cr to ready based on deployment.status = available ([#5020](#5020)) ([fce0d35](fce0d35))
* Ensure Postgres queries are committed or autocommit is used ([#5039](#5039)) ([46f8d7a](46f8d7a))
* Fixing the release workflow to refresh the stable branch when the release is not running in the dry run mode. ([#5057](#5057)) ([a13fa9b](a13fa9b))
* Operator - make onlineStore the default service ([#5044](#5044)) ([6c92447](6c92447))
* Operator - resolve infinite reconciler loop in authz controller ([#5056](#5056)) ([11e4548](11e4548))
* Resolve module on windows ([#4827](#4827)) ([efbffa4](efbffa4))
* Setting the github_token explicitly to see if that solves the problem. ([#5012](#5012)) ([3834ffa](3834ffa))
* Validate entities when running get_online_features ([#5031](#5031)) ([3bb0dca](3bb0dca))

### Features

* Add SQLite retrieve_online_documents_v2 ([#5032](#5032)) ([0fffe21](0fffe21))
* Adding Click command to display configuration details ([#5036](#5036)) ([ae68e4d](ae68e4d))
* Adding volumes and volumeMounts support to Feature Store CR. ([#4983](#4983)) ([ec6f1b7](ec6f1b7))
* Moving the job to seperate action so that we can test it easily. ([#5013](#5013)) ([b9325b7](b9325b7))
* Operator - make server container creation explicit in the CR ([#5024](#5024)) ([b16fb40](b16fb40))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants