fix: check share owner permissions on public share access - #5888
Merged
hacdias merged 1 commit intoApr 4, 2026
Merged
Conversation
Verify that the share owner still has Share and Download permissions when a public share link is accessed. Previously, withHashFile only checked that the share existed and the user existed, but did not re-validate permissions. This meant shares remained accessible after an admin revoked the owner's Share or Download permissions. Ref: GHSA-v9w4-gm2x-6rvf
hacdias
approved these changes
Apr 4, 2026
kumaraguru1735
pushed a commit
to kumaraguru1735/filebrowser-laravel
that referenced
this pull request
Apr 8, 2026
- filebrowser#5891: Check download perm for binary files in resourceGet - filebrowser#5889: Reject .. paths before realpath (defense in depth) - filebrowser#5888: Verify share owner download perm on public access - filebrowser#5848: Normalize double slashes in TUS upload paths - Add X-Content-Type-Options for epub/svg/html inline previews Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShareandDownloadpermissions when a public share link is accessedwithHashFilechecked that the share and user existed but did not re-validate permissions after revocationShareandDownloadpermissionsRef: GHSA-v9w4-gm2x-6rvf