fix: preserve registry permissions for admin groups#29
Open
3Blin wants to merge 1 commit into
Open
Conversation
Expose registry permissions in the group edit modal and include them when saving groups. Also keep the built-in protected Admin group fully privileged on save to prevent accidental admin or registry lockout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
perm_view_registryandperm_edit_registrywhen saving groupsWhy
The backend already supports registry permissions, but the group edit UI did not expose/send them. Saving groups could therefore drop registry access and hide the registry catalog from admins. The backend guard prevents the protected Admin group from losing critical permissions even if an older UI or direct API call omits fields.
Verification
PYTHONDONTWRITEBYTECODE=1 python3 -m py_compile routes/admin.pystatic/js/dashboard/admin.jscontains registry permission controls and payload fields