Fix tools test verifyVersion() regex - #41744
Merged
christopherfujino merged 6 commits intoOct 2, 2019
Merged
Conversation
christopherfujino
marked this pull request as ready for review
October 1, 2019 23:46
| - name: bots_tests-windows | ||
| skip: "!changesInclude('dev/bots/**')" | ||
| test_script: | ||
| - (cd ./dev/bots && pub run test) |
Contributor
There was a problem hiding this comment.
This gets me every time
Contributor
Author
There was a problem hiding this comment.
Yep, I fixed it and the test passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prior to this, hotfix branches would fail tools tests on pre-submit because they didn't match the version check regex.
Related Issues
#41310
Tests
Added a unit test for the
verifyVersion()method. @dnfield do you by any chance know if the tests influtter/dev/bots/testever get run (it looks to me like they don't). And I don't know that it's worth running them in Cirrus; here I added tasks for windows/linux/mac that only run ifflutter/dev/bots/**were changed.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?