feat(curriculum): add return to step 26 instructions for workshop-music-player#68278
Open
bdtripp wants to merge 1 commit into
Open
feat(curriculum): add return to step 26 instructions for workshop-music-player#68278bdtripp wants to merge 1 commit into
bdtripp wants to merge 1 commit into
Conversation
- Added an instruction for campers to include a `return` statement before the end of the `if` block - Added a test that ensures the camper included a return statement after `playSong(userData.songs[0].id)` and before the closing `}` of the `if` block - Added a hint to display when the test fails
Contributor
|
Hi there, Thanks for opening this pull request. The automated checks found some issues: Linked Issue: We kindly ask that contributors open an issue before submitting a PR so the change can be discussed and approved before work begins. This helps avoid situations where significant effort goes into something we ultimately cannot merge. Please open an issue first and allow it to be triaged. Once the issue is open for contribution, you are welcome to update this pull request to reflect the issue consensus. Until then, we will not be able to review your pull request. Join us in our chat room or our forum if you have any questions or need help with contributing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.This PR was requested by a reviewer on my previous PR #68107, who noted that the instruction change and corresponding test should be submitted separately from the audit PR.
returnstatement before the end of theifblockplaySong(userData.songs[0].id)and before the closing}of theifblock