colorize: "Melt" also over space characters#45
Merged
Conversation
This commit improves the `melt_mapped_tokens` function so that
adjacent tokens are also melted when they are separated by spaces, e.g.
{
c d e
}
will only return one <span class="lilypond-pitch"> instead of three.
Collaborator
|
I think this is nice, but shouldn't |
Collaborator
Author
|
Thanks for the hint, I wasn't aware of this function :-( |
Collaborator
|
that would allow tokens consisting of more than one space to be merged as well I guess. |
Collaborator
Author
|
I think so, and that would be good.
|
wbsoft
added a commit
that referenced
this pull request
Sep 25, 2015
colorize: "Melt" also over space characters
bryantgeorge
added a commit
to bryantgeorge/python-ly
that referenced
this pull request
Dec 19, 2019
Resolve "Support breath marks" Closes frescobaldi#45 See merge request bgeorge/python-ly!52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improves the
melt_mapped_tokensfunction so thatadjacent tokens are also melted when they are separated by spaces, e.g.
will only return one
<span class="lilypond-pitch">item instead of three.