Skip to content
This repository was archived by the owner on Jan 3, 2023. It is now read-only.

Create a FSharp.Tools NuGet package - closes #408 - #409

Merged
fsgit merged 4 commits into
fsharp:masterfrom
forki:tools
Apr 29, 2015
Merged

Create a FSharp.Tools NuGet package - closes #408#409
fsgit merged 4 commits into
fsharp:masterfrom
forki:tools

Conversation

@forki

@forki forki commented Apr 28, 2015

Copy link
Copy Markdown
Member

what else do we need?

/cc @dsyme @granicz

@dsyme

dsyme commented Apr 28, 2015

Copy link
Copy Markdown
Contributor

Well, you need FSharp.Compiler.dll, FSharp.Compiler.Server.Shared.dll, FSharp.Compiler.InteractiveSettings.dll, fsiAnyCpu.exe. I also think it's correct to add FSharp.Build.dll and Microsoft.FSharp.Targets - in theory they feel as if they could be in a separate package, but I believe FSharp.Build.dll looks for fsc.exe in the same directory that it resides in by default, so it's appropriate to bundle them.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toes? ToDos? TuTus?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@tpetricek

Copy link
Copy Markdown
Member

I think this might still not work out-of-the box if you run this on a clean machine (i.e. Azure VM).

At least I recently tried running FSharp.Compiler.Service.dll on an Azure VM with plain OS and it did not work - it turns out that FSharp.Compiler.Service.dll has dependencies on some MSBUILD stuff (Microsoft.Build.dll and a bunch of others) that are not available on clean install with .NET and have to be installed separately.

Not sure if we can get the MSBUILD stuff from NuGet as a dependency or something...?

@forki

forki commented Apr 28, 2015

Copy link
Copy Markdown
Member Author

ok I added these. I wonder if we should depend on FSharp.Core package, but I assume since we are an app this is not really a good idea and we would need to copy files anyway,

@granicz

granicz commented Apr 28, 2015

Copy link
Copy Markdown

Hmm, Tomas, do you remember what dependencies were those?

@dsyme

dsyme commented Apr 28, 2015

Copy link
Copy Markdown
Contributor

Yes, for this I believe you should add all the relevant MSBuild DLLs as local copies. I think you can just change these references to be <Private>True</Private> and add the DLLs from the release directory.

The whole thing would definitely need to be tested on OSX, Linux and Windows. Ideally you would package + test as part of CI.

@forki

forki commented Apr 28, 2015

Copy link
Copy Markdown
Member Author

will look at this tomorrow. Now I have to watch Bayern vs. BVB ;-)

2015-04-28 20:06 GMT+02:00 Don Syme notifications@github.com:

Yes, for this I believe you should add all the relevant MSBuild DLLs as
local copies. I think you can just change these references
https://github.com/fsharp/fsharp/blob/master/src/fsharp/FSharp.Compiler/FSharp.Compiler.fsproj#L512
to be True and add the DLLs from the directory.


Reply to this email directly or view it on GitHub
#409 (comment).

@dsyme

dsyme commented Apr 28, 2015

Copy link
Copy Markdown
Contributor

Yes, first things first @forki !

@forki

forki commented Apr 29, 2015

Copy link
Copy Markdown
Member Author

done

@dsyme

dsyme commented Apr 29, 2015

Copy link
Copy Markdown
Contributor

Could you change the name per this comment

@forki

forki commented Apr 29, 2015

Copy link
Copy Markdown
Member Author

done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this one (Microsoft.Build?)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

fsgit added a commit that referenced this pull request Apr 29, 2015
Create a FSharp.Tools NuGet package - closes #408
@fsgit
fsgit merged commit a4e1f71 into fsharp:master Apr 29, 2015
7sharp9 pushed a commit to 7sharp9/fsharp that referenced this pull request Jul 31, 2015
7sharp9 pushed a commit to 7sharp9/fsharp that referenced this pull request Jul 31, 2015
7sharp9 pushed a commit to 7sharp9/fsharp that referenced this pull request Jul 31, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants