Skip to content
This repository was archived by the owner on Jan 3, 2023. It is now read-only.

Update targets.make - #463

Merged
dsyme merged 1 commit into
fsharp:masterfrom
7sharp9:patch-2
Jul 31, 2015
Merged

Update targets.make#463
dsyme merged 1 commit into
fsharp:masterfrom
7sharp9:patch-2

Conversation

@7sharp9

@7sharp9 7sharp9 commented Jul 31, 2015

Copy link
Copy Markdown
Member

Added v11.00 target locations as the current mono's $(VisualStudioVersion) resolved to this.

@7sharp9
Update targets.make
5509241 
Added v11.00 target locations as the current mono's $(VisualStudioVersion) resolved to this.
@rneatherway

rneatherway commented Jul 31, 2015

Copy link
Copy Markdown
Member

Wow when did that happen! Is it necessary given that F# project files normally contain:

    <When Condition="'$(VisualStudioVersion)' == '11.0'">
      <PropertyGroup Condition="Exists('$(MSBuildExtensionsPath32)\..\Microsoft SDKs\F#\3.0\Framework\v4.0\Microsoft.FSharp.Targets')">
        <FSharpTargetsPath>$(MSBuildExtensionsPath32)\..\Microsoft SDKs\F#\3.0\Framework\v4.0\Microsoft.FSharp.Targets</FSharpTargetsPath>
      </PropertyGroup>
    </When>

@7sharp9

7sharp9 commented Jul 31, 2015

Copy link
Copy Markdown
Member Author

I have no idea what exists in the wild, the default F# console in XS will look like:

<Import Project="$(MSBuildExtensionsPath32)\..\Microsoft SDKs\F#\3.1\Framework\v4.0\Microsoft.FSharp.Targets" />

@dsyme

dsyme commented Jul 31, 2015

Copy link
Copy Markdown
Contributor

Seems safe to add these, may as well

dsyme added a commit that referenced this pull request Jul 31, 2015
@dsyme
Merge pull request #463 from 7sharp9/patch-2
a89330f 
Update targets.make
@dsyme
dsyme merged commit a89330f into fsharp:master Jul 31, 2015
@dsyme

dsyme commented Jul 31, 2015

Copy link
Copy Markdown
Contributor

Pushed tag 4.0.0.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@7sharp9 @rneatherway @dsyme