fixup! Win32: change default of 'core.symlinks' to false#1744
Conversation
Revert this change, as it does not take into account that Windows 10 now allows all users to create symbolic links in developer mode. Noticed by Ed Thomson. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
🤔 I don't have the background to make intelligent comments about this patch - that an environment variable sets up some larger behavioral changes down the road is a little opaque to me. I'll trust that it updates the behaviors as described. But thinking about this further: while I think that detecting |
|
To clarify my last point further: I can imagine that there are workflows where an administrator runs |
Yep. And if you care to look at the test failures, that seems to be exactly what is happening, with the predictable problems on Windows: the idea of MSYS2's Bash of what a symbolic link is differs drastically from what I would now usually point out how inappropriate the choice of Unix shell scripting is to implement a test framework, but you probably 😪 of my complaint by now. |
|
The more I think about the status quo, the happier that I am with it. Opt-in support for |
Okay! |
Revert this change, as it does not take into account that Windows 10 now
allows all users to create symbolic links in developer mode.
Noticed by Ed Thomson.
Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de
Thanks for taking the time to contribute to Git!
Those seeking to contribute to the Git for Windows fork should see
http://gitforwindows.org/#contribute on how to contribute Windows specific enhancements.
If your contribution is for the core Git functions and documentation
please be aware that the Git community does not use the github.com issues
or pull request mechanism for their contributions.
Instead, we use the Git mailing list (git@vger.kernel.org) for code and
documenatation submissions, code reviews, and bug reports. The
mailing list is plain text only (anything with HTML is sent directly
to the spam folder).
Nevertheless, you can use submitGit to conveniently send your Pull
Requests commits to our mailing list.
Please read the "guidelines for contributing" linked above!