This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Call MenuCommandService.AddCommand on Main thread - #1522
Merged
Conversation
Calling on background thread can cause deadlock.
grokys
approved these changes
Mar 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now use the following attribute on
GitHubPackage:It appears the
PackageAutoLoadFlags.BackgroundLoadflag is only honored on Visual Studio 2017. This caused the menu initialization to only execute on a background thread when using Visual Studio 2017. This would cause a deadlock. 😭Fixes #1520