Fix indicateDefaultOption erroring when no options are visible - #61
Merged
Conversation
iansan5653
commented
Jul 20, 2022
Comment on lines
+292
to
+297
| it('does not error when no options are visible', () => { | ||
| assert.doesNotThrow(() => { | ||
| document.getElementById('list-id').style.display = 'none' | ||
| combobox.clearSelection() | ||
| }) | ||
| }) |
Member
Author
There was a problem hiding this comment.
I confirmed - the test does fail without this fix
jfuchs
approved these changes
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the list is hidden (ie,
display:none),indicateDefaultOptionis throwing an error:The expected behavior is to do nothing in this case, as it's common to call
stop()after hiding the list. Whenstart()is called again, the default option will then be indicated.This fixes the bug by using optional chaining to only call
setAttributeif the element is found. Also added a test for this case.