Introduce combobox-select event - #76
Merged
Merged
Conversation
|
👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Primer first responder will review it soon.
|
keithamus
reviewed
Sep 14, 2023
keithamus
approved these changes
Sep 14, 2023
keithamus
left a comment
Contributor
There was a problem hiding this comment.
This LGTM. @camertron or @langermank as our FR can merge this and cut a release 🙂 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an event called
combobox-selectwhich is fired when an item is focused but not yet committed.This can be useful if you want to build an autocompletion while navigating through the options without actual committing a selection by hitting enter (similar to the spotlight search on mac-os).
I hope this also sounds useful to you too.