Skip to content

Use "nearest" behavior for scrollIntoView - #79

Merged
keithamus merged 1 commit into
github:mainfrom
wxiaoguang:main
Dec 23, 2023
Merged

Use "nearest" behavior for scrollIntoView#79
keithamus merged 1 commit into
github:mainfrom
wxiaoguang:main

Conversation

@wxiaoguang

@wxiaoguang wxiaoguang commented Dec 23, 2023

Copy link
Copy Markdown
Contributor

@keithamus keithamus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keithamus
keithamus merged commit ea5e8d6 into github:main Dec 23, 2023
@keithamus

Copy link
Copy Markdown
Contributor

wxiaoguang added a commit to go-gitea/gitea that referenced this pull request Dec 24, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 24, 2023
wxiaoguang added a commit to go-gitea/gitea that referenced this pull request Dec 25, 2023
Backport #28597 by wxiaoguang

Fix #28595 by github/combobox-nav#79 (combobox-nav v2.3.1)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Jan 16, 2024
Backport #28597 by wxiaoguang

Fix #28595 by github/combobox-nav#79 (combobox-nav v2.3.1)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
(cherry picked from commit 8a46a64)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
zeekay pushed a commit to hanzoai/git that referenced this pull request Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The UX is broken with v2.3.0 of @github/combobox-nav dependency

2 participants