few small diff view improvements#551
Merged
Merged
Conversation
Contributor
|
Please can you provide a before-image and a after-image ? |
f18bd44 to
7de7097
Compare
Contributor
Author
|
@hannesa2 I've added screenshots to the PR description and rebased yesterday |
Contributor
|
Based on you screenshots, the diffs looks like this both background and top link positioning
only top link positioning
file name stickiness
ditto
As you can see, only with the file name stickness the screenshot doesn't really reflect the change. But this is not an issue. Btw, my don't-run-screenshot-compare-on-fork change doesn't work. To test it with your pull request was a non working shortcut 😞 |
4e61fe2 to
7de7097
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
please tell me if I should split into separate PRs