fix(internal): bounds-check skipWhiteSpace to prevent OOB read - #595
Closed
AruneshDwivedi wants to merge 1 commit into
Closed
fix(internal): bounds-check skipWhiteSpace to prevent OOB read#595AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
The skipWhiteSpace function in both encoder and decoder loops over buffer bytes without checking the cursor is within bounds. When JSON input contains only whitespace or reaches a buffer boundary, the loop increments past len(buf) causing an index out of range panic. Fixed by adding 'cursor < int64(len(buf))' guard before array access in both encoding path (internal/encoder/compact.go) and decoding path (internal/decoder/context.go). Signed-off-by: Kushal Dwivedi <arunesh.devops@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skipWhiteSpace function in both encoder and decoder loops over
buffer bytes without checking the cursor is within bounds.
When JSON input contains only whitespace or reaches a buffer boundary,
the loop increments past len(buf) causing an index out of range panic.
Fixed by adding
cursor < int64(len(buf))guard before array accessin both encoding path (internal/encoder/compact.go) and decoding path
(internal/decoder/context.go).
This matches the same pattern already used in the StreamDecoder variant
at internal/decoder/stream.go line 238.