build: fix mkfs.ext4 invocation - #11
Merged
Merged
Conversation
This currently fails with: mkfs.ext4: invalid blocks '-F' on device 'fscryptctl_image' The reason is that that the argument after the device name is treated as the file system size. Move -F in the command line to make it work. Signed-off-by: André Draszik <git@andred.net>
Member
|
Looks like changing the arguments order didn't break Travis, so LGTM. @andred, what version of e2fsprogs were you using? I wasn't able to get the old version to break. |
Contributor
Author
|
Thanks. @josephlr This was using v1.43.4 of e2fsprogs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This currently fails with:
mkfs.ext4: invalid blocks '-F' on device 'fscryptctl_image'
The reason is that that the argument after the device name
is treated as the file system size.
Move -F in the command line to make it work.
Signed-off-by: André Draszik git@andred.net