remove blob_href from check annotations - #1242
Conversation
gmlewis
left a comment
There was a problem hiding this comment.
Thanks, @mcristina422.
Travis-CI is complaining that there is a test failing. I looked into it, and it appears that there is one more blob_href references here:
https://github.com/google/go-github/blob/master/github/checks_test.go#L597
that needs to be removed.
After that is fixed, it LGTM and then we can merge after getting a second LGTM.
Codecov Report
@@ Coverage Diff @@
## master #1242 +/- ##
=======================================
Coverage 73.42% 73.42%
=======================================
Files 86 86
Lines 6040 6040
=======================================
Hits 4435 4435
Misses 836 836
Partials 769 769
Continue to review full report at Codecov.
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @mcristina422!
LGTM.
Awaiting second LGTM before merging.
Note to self: this is a breaking API change and will require a major version bump.
|
Thank you, @gauntface! |
|
@gmlewis yeah, I think you're right. But that just means the next time a new version is tagged it should bump the major version. It doesn't necessarily mean we need to tag this right away. |
|
Oh, OK. Do you have a preference, @willnorris ? I've been attempting to release&tag after each PR just in case we need to refer to a specific version (so that we don't have to use a commit or PR as our reference), but I can reduce the frequency if you prefer. I'll go ahead and continue catching up with the outstanding PRs while I've been without internet, and then make a new release and tag, and that should hopefully reduce the noise. |
|
Ah! I see you opened #1280 for discussion. Excellent. We can continue there. |
BREAKING
As defined on https://developer.github.com/v3/checks/runs/#annotations-object
blob_hrefis no longer a parameter.Opening this as discussed in #1241 (review)