Skip to content

React 18 in peer-dependencies and use new API#1103

Merged
karldanninger merged 1 commit into
google-map-react:masterfrom
derkoe:react-18
Jul 5, 2022
Merged

React 18 in peer-dependencies and use new API#1103
karldanninger merged 1 commit into
google-map-react:masterfrom
derkoe:react-18

Conversation

@derkoe

@derkoe derkoe commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

Closes #1102

@alexcastrodev

alexcastrodev commented Apr 16, 2022

Copy link
Copy Markdown

Thanks @derkoe ❤️

@SimantoR SimantoR mentioned this pull request Apr 19, 2022
Open
@mdfahadhossain

mdfahadhossain commented Apr 22, 2022

Copy link
Copy Markdown

Waiting for this change.

@SmartMan1226

SmartMan1226 commented Apr 22, 2022

Copy link
Copy Markdown

I hope this will also solve #1110

@BrandonCopley

BrandonCopley commented May 12, 2022

Copy link
Copy Markdown

How can I help get this into production?

@tetarchus

tetarchus commented May 12, 2022

Copy link
Copy Markdown

@karldanninger @itsmichaeldiego - Are you able to merge and release this PR to allow upgrading to React 18?

@dryan-FF dryan-FF mentioned this pull request Jun 2, 2022
Closed
@Gervwyk

Gervwyk commented Jun 16, 2022

Copy link
Copy Markdown

Would be great if this can be released!

stephencweiss
stephencweiss reviewed Jun 17, 2022
View reviewed changes
Comment thread example/src/App.test.js
@joaogarin

joaogarin commented Jun 23, 2022

Copy link
Copy Markdown

Would be lovely to get this released and unblock people using the library to move to React 18 =)

@troiscodes

troiscodes commented Jun 23, 2022

Copy link
Copy Markdown

Please release it 👯

@ArnaudSantucci

ArnaudSantucci commented Jun 23, 2022 •
edited
Loading

Copy link
Copy Markdown

Yes plz !! release it 🥇

@itsmichaeldiego ??

@asdutoit

asdutoit commented Jun 30, 2022

Copy link
Copy Markdown

??

@karldanninger karldanninger merged commit c12b94f into google-map-react:master Jul 5, 2022
@karldanninger

karldanninger commented Jul 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Sorry this took so long... We need to get better at maintaining this package.
I've merged this and set a release for 2.2.

Let me know if this is enough for npm to serve this latest version.

@jacobgad

jacobgad commented Jul 6, 2022

Copy link
Copy Markdown

i don't believe this is enough for npm to serve the latest version. As you can see here:
https://www.npmjs.com/package/google-map-react

it is still serving 2.1.10

@derkoe derkoe deleted the react-18 branch July 6, 2022 06:05
@derkoe

derkoe commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

@karldanninger somebody has to publish the package manually since there are no CI jobs setup (the last version was published by @itsmichaeldiego)

@karldanninger

karldanninger commented Jul 6, 2022

Copy link
Copy Markdown
Contributor

I've contacted @itsmichaeldiego, will try to get this expedited.

@itsmichaeldiego

itsmichaeldiego commented Jul 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Done @karldanninger @derkoe. Let me know!

@antoniocosentino antoniocosentino mentioned this pull request Jul 6, 2022
Closed
@asdutoit

asdutoit commented Jul 7, 2022

Copy link
Copy Markdown

Many thanks!

@itsmichaeldiego

itsmichaeldiego commented Sep 8, 2022

Copy link
Copy Markdown
Member

@derkoe @karldanninger @dryan-FF Seems that there's an issue still #1129 (comment), could you guys check it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers
@stephencweiss stephencweiss stephencweiss left review comments
@geangu geangu geangu approved these changes
@bnussman bnussman bnussman approved these changes
@ArnaudSantucci ArnaudSantucci ArnaudSantucci approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

React 18 Support