This repository was archived by the owner on Dec 17, 2023. It is now read-only.
feat!: use microgenerator#239
Merged
Merged
Conversation
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
busunkim96
commented
Dec 10, 2020
| display_name=display_name, mime_type=mime_type, | ||
| content_uri=content_uri) | ||
|
|
||
| document.knowledge_types.append( | ||
| dialogflow.types.Document.KnowledgeType.Value(knowledge_type)) | ||
| getattr(dialogflow.Document.KnowledgeType, knowledge_type) |
Contributor
Author
There was a problem hiding this comment.
Is this an acceptable way to go from a string to the enum, or should I do something else? @software-dov
class KnowledgeType(proto.Enum):
r"""The knowledge type of document content."""
KNOWLEDGE_TYPE_UNSPECIFIED = 0
FAQ = 1
EXTRACTIVE_QA = 2
Contributor
Author
|
@software-dov @leahecole This is now ready for review. :) |
Contributor
|
I don't know too much about dialogflow, but the tests passing is a good sign to me, and the upgrading guide looks good! |
software-dov
approved these changes
Dec 14, 2020
software-dov
left a comment
There was a problem hiding this comment.
UPGRADING looks good, samples look good. I'm guessing the samples all run.
Merged
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Dec 14, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [2.0.0](https://www.github.com/googleapis/python-dialogflow/compare/v1.1.0...v2.0.0) (2020-12-14) ### ⚠ BREAKING CHANGES * use microgenerator. See [Migration Guide](https://github.com/googleapis/python-dialogflow/blob/master/UPGRADING.md). (#239) ### Features * use microgenerator ([#239](https://www.github.com/googleapis/python-dialogflow/issues/239)) ([57c90a5](https://www.github.com/googleapis/python-dialogflow/commit/57c90a5b72668e599047b358f634f939d70a051f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opening #227 for cleaner comment history and reviewer list.
"Jump to" doesn't work because there are too many files. Here are direct links: