This repository was archived by the owner on Feb 26, 2026. It is now read-only.
docs: fix the docstring comment for LogEntry.severity#740
Closed
ymotongpoo wants to merge 2 commits into
Closed
Conversation
added 2 commits
April 7, 2023 13:38
* change the type of LogEntry.severity from str to log_severity_pb2.LogSeverity
Contributor
|
I believe this is an auto-generated file, so I'm not sure if this is the right place to make this change |
Contributor
Author
|
@daniel-sanche then which is the original? I could not other files that has this document comments in this repository. |
Contributor
|
Sorry, I just checked again and while this file is similar to an autogenerated file, this one is not controlled by a template. My mistake As discussed in #739 though, I believe the intention of the hand-written portion of the library is to use string representations for severity, so if we're able to fix the bug in #739, this change shouldn't be needed. Thanks! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #739 🦕