Skip to content
This repository was archived by the owner on Feb 26, 2026. It is now read-only.

feat: add logic to convert severity string to uppercase #744

Merged
daniel-sanche merged 7 commits into from
Apr 21, 2023
Merged

feat: add logic to convert severity string to uppercase #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a4a2586
add logic to convert severity str to uppercase
Apr 13, 2023
3fd66d0
revert import section
Apr 13, 2023
f61c311
nit
Apr 13, 2023
7179d89
add test for lowercase severity
Apr 17, 2023
9434923
Merge branch 'main' into master
daniel-sanche Apr 18, 2023
2061729
Merge branch 'main' into master
Apr 19, 2023
b05e1fc
nit: run lint
Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion google/cloud/logging_v2/entries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,10 @@ def to_api_repr(self):
if self.insert_id is not None:
info["insertId"] = self.insert_id
if self.severity is not None:
info["severity"] = self.severity
if isinstance(self.severity, str):
info["severity"] = self.severity.upper()
else:
info["severity"] = self.severity
if self.http_request is not None:
info["httpRequest"] = self.http_request
if self.timestamp is not None:
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/logging_v2/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def _do_log(self, client, _entry_class, payload=None, **kw):
kw["resource"] = kw.pop("resource", self.default_resource)

severity = kw.get("severity", None)
if isinstance(severity, str) and not severity.isupper():
if isinstance(severity, str):
# convert severity to upper case, as expected by enum definition
kw["severity"] = severity.upper()

Expand Down
Loading