Require that every submitted command buffer must be unique - #4593
Merged
Conversation
Contributor
|
Previews, as seen when this build job started (f0c4b06): |
8 tasks
kainino0x
approved these changes
Apr 24, 2024
kainino0x
left a comment
Contributor
There was a problem hiding this comment.
This was definitely the intent (otherwise you can't record directly into Vulkan command buffers) but I'm adding tacit resolution queue as FYI to the WG.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4367
Requires that every command buffer in a single submit be unique.
There's a couple of other ways that this could be handled, but this feels the most elegant. It's worth noting that this scenario doesn't appear to be tested in the CTS and I suspect that implementations may not be handling it correctly either.