-
Notifications
You must be signed in to change notification settings - Fork 375
Specify immediate data API and WGSL <immediate> address space #5423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
9aefc38
Specify immediate data API in the WebGPU spec
shaoboyan091 5f99456
Update spec/index.bs
shaoboyan091 bffe39d
Update spec/index.bs
shaoboyan091 ad13b13
Specify <immediate> address space
shaoboyan091 895beb8
Update wgsl/index.bs
shaoboyan091 21ba7fa
Update wgsl/index.bs
shaoboyan091 b045b81
Address comments
shaoboyan091 f2653d8
Address comments
shaoboyan091 d33528e
Address comments
shaoboyan091 b8243f4
Apply suggestions from code review
shaoboyan091 5ab1e43
Update wgsl/index.bs
shaoboyan091 08c755a
WGSL: don't describe immediate data as part of the resource interface
dneto0 e68f1c1
Simplify description of max immediate variable size
dneto0 3fa0d5c
Address comments
shaoboyan091 b16cc9e
Address comments in spec/index.bs.
shaoboyan091 8c2b204
Update spec/index.bs
shaoboyan091 5cce2cd
Merge branch 'main' into gpu-spec
shaoboyan091 589c87b
Apply suggestions from code review
shaoboyan091 87585b1
Address comments
shaoboyan091 fbde276
Move maxImmediateSize alignment requirement to adapter-capability-gu…
shaoboyan091 e77030a
Merge branch 'main' into gpu-spec
shaoboyan091 7cc2469
Address review comments on immediate data validation
shaoboyan091 f2fc3f3
editorial: Validate immediate data
kainino0x File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.