Skip to content

chore: testing against both java-11 and java-17#525

Merged
rjurney merged 2 commits into
graphframes:masterfrom
SemyonSinchenko:463-java-17
Feb 26, 2025
Merged

chore: testing against both java-11 and java-17#525
rjurney merged 2 commits into
graphframes:masterfrom
SemyonSinchenko:463-java-17

Conversation

@SemyonSinchenko

Copy link
Copy Markdown
Collaborator

What changes were proposed in this pull request?

scala-ci matrix is extended by adding testing against java-17

All the necessary --add-opens are added to the build.sbt

Why are the changes needed?

As described in #463

Close #463

@SemyonSinchenko

Copy link
Copy Markdown
Collaborator Author

@rjurney @bjornjorgensen Hello! This one is very small, please take a look when you have time! Thanks!

@bjornjorgensen bjornjorgensen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjurney

rjurney commented Feb 26, 2025

Copy link
Copy Markdown
Collaborator

lgtm, love it!

@rjurney rjurney closed this Feb 26, 2025
@rjurney

rjurney commented Feb 26, 2025

Copy link
Copy Markdown
Collaborator

Ooops.

@rjurney rjurney reopened this Feb 26, 2025
@rjurney rjurney merged commit d96e8a3 into graphframes:master Feb 26, 2025
@SemyonSinchenko SemyonSinchenko deleted the 463-java-17 branch April 6, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Java 17+

3 participants