Skip to content

fix: meeting_stats -> 404 for nonexistent meeting - #10896

Merged
jennifer-richards merged 4 commits into
ietf-tools:mainfrom
jennifer-richards:meeting-stats-404
May 21, 2026
Merged

fix: meeting_stats -> 404 for nonexistent meeting#10896
jennifer-richards merged 4 commits into
ietf-tools:mainfrom
jennifer-richards:meeting-stats-404

Conversation

@jennifer-richards

Copy link
Copy Markdown
Member

Fixes #10892

@jennifer-richards

Copy link
Copy Markdown
Member Author

@evyncke

@evyncke

evyncke commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Good addition indeed !

Now, I need to merge the changes into the PR #10815 ;-)

rjsparks
rjsparks previously approved these changes May 19, 2026
@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.51%. Comparing base (e37a2c9) to head (cf5a3a7).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
ietf/stats/views.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10896      +/-   ##
==========================================
- Coverage   88.51%   88.51%   -0.01%     
==========================================
  Files         332      332              
  Lines       44970    44970              
==========================================
- Hits        39807    39806       -1     
- Misses       5163     5164       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jennifer-richards
jennifer-richards merged commit 35b4048 into ietf-tools:main May 21, 2026
9 checks passed
@jennifer-richards
jennifer-richards deleted the meeting-stats-404 branch May 21, 2026 16:17
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Requesting meeting stats for nonexistent meeting causes 500 server error

3 participants