fix: use RfcAuthor in bibtex (w/titlepage_name) - #10947
Merged
jennifer-richards merged 7 commits intoJul 10, 2026
Merged
Conversation
rjsparks
previously approved these changes
May 29, 2026
Remove a case that tests fallback from RfcAuthor to DocumentAuthor since we now always have RfcAuthors. Remove RfcAuthor records when deleting Persons they refer to, since we don't allow cascade on this model.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10947 +/- ##
=======================================
Coverage 88.58% 88.59%
=======================================
Files 333 333
Lines 44662 44669 +7
=======================================
+ Hits 39565 39573 +8
+ Misses 5097 5096 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rjsparks
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the bibtex template to work with
RfcAuthorwhen present.Uses
titlepage_nameinstead ofperson.nameand uses the current ordering, so e.g.,becomes
That change will affect all RFCs, not just the new ones. This should bring it into better agreement with the RFC index / RFCs themselves, so I think it's a feature.
Fixes #10944. Fixes #10948.