fix: Use primary address for ballot email from for non ietf-stream docs - #11119
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11119 +/- ##
=======================================
Coverage 88.51% 88.52%
=======================================
Files 334 334
Lines 45102 45105 +3
=======================================
+ Hits 39924 39931 +7
+ Misses 5178 5174 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jennifer-richards
approved these changes
Jun 30, 2026
| if create and extracted: | ||
| make_email = getattr(EmailFactory, 'create' if create else 'build') | ||
| make_email(person=obj, address=obj.user.email) | ||
| make_email(person=obj, address=obj.user.email, primary=True, **kwargs) |
Member
There was a problem hiding this comment.
nit: the if create... is always true since this is in a block where create and extracted is true, so this could just be EmailFactory.create() and the previous line could be removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11114
Note that this changes the default behavior of the Person factory to generate a primary Email object for the Person.