Skip to content

fix: filter idexists documents from AD results - #11433

Open
alloutflo wants to merge 2 commits into
ietf-tools:mainfrom
alloutflo:codex/issue-8231-filter-id-exists
Open

fix: filter idexists documents from AD results#11433
alloutflo wants to merge 2 commits into
ietf-tools:mainfrom
alloutflo:codex/issue-8231-filter-id-exists

Conversation

@alloutflo

@alloutflo alloutflo commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown

This PR was prepared with Codex assistance.

Summary

  • Filter all draft-iesg documents in the idexists state from /doc/ad results, alongside dead.
  • Remove the now-redundant expired + idexists special case.
  • Add regression coverage proving both dead and idexists drafts stay out of AD results.

Tests

  • ./ietf/manage.py test --settings=settings_test --ignore-lower-coverage --no-manage-blobstore --no-validate-html ietf.doc.tests.SearchTests.test_docs_for_ad (6 passed)
  • ./ietf/manage.py test --settings=settings_test --ignore-lower-coverage --no-manage-blobstore ietf.doc.tests (104 passed; HTML validation enabled)
  • git diff --check

Fixes #8231

Draft gate: maintainer approval is required to start the two fork-origin GitHub Actions workflows (PR - Run All Tests and Dependency Review); both must pass before this PR is marked ready.

@alloutflo

alloutflo commented Aug 9, 2026

Copy link
Copy Markdown
Author

@rjsparks Maintainer handoff: contributor-side work is complete at 5adeb249. The PR is mergeable, up to date with main, and has no review comments or open threads. The focused search tests (6) and full ietf.doc.tests suite (104) pass locally, and Semantic PR is green.

GitHub is holding PR - Run All Tests and Dependency Review at action_required; both runs contain 0 jobs until a maintainer approves them. Could you or another maintainer approve those runs? I’ll keep the PR in draft until both complete successfully.

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.60%. Comparing base (b5b78cd) to head (5adeb24).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11433      +/-   ##
==========================================
+ Coverage   88.58%   88.60%   +0.01%     
==========================================
  Files         333      333              
  Lines       44728    44780      +52     
==========================================
+ Hits        39624    39679      +55     
+ Misses       5104     5101       -3

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alloutflo
alloutflo marked this pull request as ready for review August 10, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Filter docs in draft-iesg id-exists state out of /doc/ad results

1 participant

@alloutflo