BitReader throw exception when input is exhausted.#384
Open
avrecko wants to merge 1 commit into
Open
Conversation
To prevent infinite loop on bad h264 data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It happened that on some bad data we get in infinite loop inside the SliceHeaderReader#readReorderingEntries method.
I've made it possible to supply a BitReader that throws exception when input is exhausted. This way if an infinite loop happens the BitReader#readInt() will eventually throw IllegalStateException instead of returning 0 and looping forever.
I need extra safety also for H264 Sps and Pps that is why I added read methods that take BitReader as an argument.