This repository was archived by the owner on Aug 15, 2022. It is now read-only.
go/makefile: add -race flag for social tests - #10233
Merged
Merged
Conversation
Contributor
Author
|
before review & merge this PR, we need to merge #10155 |
cihangir
reviewed
Jan 11, 2017
| @`which go` test -c workers/realtime/models/*.go | ||
| @./models.test $(DBG) $(EXTRAS) -c $(CONFIG) | ||
| @rm ./models.test | ||
| @env COMPILE_FLAGS="-race" $(KODINGDIR)/scripts/gotests.sh socialapi socialapi/workers/realtime/models |
Contributor
There was a problem hiding this comment.
instead of adding race here, having it in gotests would be better, ignore me if you are just eliminating them one by one for now.
Contributor
Author
There was a problem hiding this comment.
i've added as a note for this '-race' usage in PR description. its just to test step by step for now
mehmetalisavas
force-pushed
the
race-flag-tests
branch
from
January 13, 2017 02:24
41e2bd3 to
159f301
Compare
Current coverage is 29.96% (diff: 100%)@@ master #10233 diff @@
==========================================
Files 93 93
Lines 11068 11068
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 3308 3317 +9
+ Misses 7417 7409 -8
+ Partials 343 342 -1
|
mehmetalisavas
force-pushed
the
race-flag-tests
branch
from
January 13, 2017 17:31
159f301 to
106ad16
Compare
mehmetalisavas
force-pushed
the
race-flag-tests
branch
from
January 17, 2017 18:18
3dd2388 to
0da400d
Compare
mehmetalisavas
commented
Jan 23, 2017
mehmetalisavas
left a comment
Contributor
Author
There was a problem hiding this comment.
solved with capturing variables
| for _, test := range tests { | ||
| t.Run(test.name, func(t *testing.T) { | ||
| t.Parallel() | ||
| // t.Parallel() |
Contributor
Author
There was a problem hiding this comment.
still needs to be fixed. parallelling does race condition
cihangir
approved these changes
Jan 24, 2017
cihangir
approved these changes
Jan 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add -race flag for tests
Note: ENV variables are used for testing step by step all tests files, i will make '-race' flag as default in bash script and will remove COMPILE_FLAGS variable