This repository was archived by the owner on Aug 15, 2022. It is now read-only.
Machine mount - add head mount handler to machine group. - #10362
Merged
Conversation
1 task
ppknap
force-pushed
the
machine_mount_machinegroup_head
branch
from
January 20, 2017 06:42
c29a908 to
a7031c4
Compare
Contributor
|
dependant PR is merged, we can rebase this |
added 5 commits
January 23, 2017 15:15
ppknap
force-pushed
the
machine_mount_machinegroup_head
branch
from
January 23, 2017 14:17
a7031c4 to
204d664
Compare
Contributor
Author
|
@cihangir @rjeczalik rebased |
rjeczalik
reviewed
Jan 23, 2017
| // HeadMountResponse defines machine group head mount response. | ||
| type HeadMountResponse struct { | ||
| // ExistMountID is not empty when mount to a given remote folder already exists. | ||
| ExistMountID mount.ID `json:"existMountID"` |
Contributor
There was a problem hiding this comment.
According to the doc it can be empty - how about making it json:"existMountID,omitempty"?
rjeczalik
reviewed
Jan 23, 2017
| AllDiskSize int64 `json:"allDiskSize"` | ||
| } | ||
|
|
||
| // HeadMount retrieves information on existing mount or prepares remote machine |
rjeczalik
approved these changes
Jan 23, 2017
cihangir
approved these changes
Jan 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
#10358Code coverage: 48.0% of statements
How Has This Been Tested?
Unit tests.
Screenshots (if appropriate):
none
Types of changes