This repository was archived by the owner on Aug 15, 2022. It is now read-only.
kd: add daemon subcommand - #10394
Merged
Merged
Conversation
rjeczalik
force-pushed
the
kd-install
branch
3 times, most recently
from
January 28, 2017 17:44
0c1fa51 to
8348669
Compare
rjeczalik
force-pushed
the
kd-install
branch
2 times, most recently
from
February 8, 2017 12:04
16ec33d to
e446a86
Compare
rjeczalik
force-pushed
the
kd-install
branch
9 times, most recently
from
February 23, 2017 20:49
3b1ac18 to
46e046e
Compare
rjeczalik
force-pushed
the
kd-install
branch
from
February 25, 2017 11:20
46e046e to
6e6973a
Compare
Codecov Report
@@ Coverage Diff @@
## master #10394 +/- ##
==========================================
+ Coverage 32.34% 32.55% +0.21%
==========================================
Files 103 102 -1
Lines 11938 12066 +128
==========================================
+ Hits 3861 3928 +67
- Misses 7644 7702 +58
- Partials 433 436 +3Continue to review full report at Codecov.
|
rjeczalik
force-pushed
the
kd-install
branch
3 times, most recently
from
March 16, 2017 17:24
c73f25e to
8f5fbe3
Compare
rjeczalik
force-pushed
the
kd-install
branch
4 times, most recently
from
March 23, 2017 21:46
18ca23b to
0f5547b
Compare
Codecov Report
@@ Coverage Diff @@
## master #10394 +/- ##
=========================================
- Coverage 30.9% 30.8% -0.1%
=========================================
Files 100 100
Lines 11323 11329 +6
=========================================
Hits 3500 3500
- Misses 7423 7429 +6
Partials 400 400Continue to review full report at Codecov.
|
Since KD starts now Klient, it can't hold the lock for konfig.bolt, otherwise Klient won't be able to read configuration. This PR reworks config to take a lock each time a write to konfig.bolt is needed.
Fixes: ❯ kd template list ID TITLE SLUG OWNER TEAM ACCESS MACHINES panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1be572d] goroutine 1 [running]: vendor/github.com/codegangsta/cli.HandleAction.func1(0xc4204181c0) /Users/rjeczalik/src/github.com/koding/koding/go/src/vendor/github.com/codegangsta/cli/app.go:472 +0x28d panic(0x1d856a0, 0x26d88d0) /Users/rjeczalik/go/src/runtime/panic.go:489 +0x2cf main.printTemplates(0xc4203f6000, 0x7, 0x9) /Users/rjeczalik/src/github.com/koding/koding/go/src/koding/klientctl/template.go:161 +0x24d
Print meaningful error message instead of:
error installing "Koding account": kloudError: Bad request (error code: 415) (e654f1c11752105a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.