Skip to content

fix: don't quote column names in list_indices#7503

Open
dantasse wants to merge 2 commits into
lance-format:mainfrom
dantasse:dantasse/quote-index-column-names
Open

fix: don't quote column names in list_indices#7503
dantasse wants to merge 2 commits into
lance-format:mainfrom
dantasse:dantasse/quote-index-column-names

Conversation

@dantasse

@dantasse dantasse commented Jun 26, 2026

Copy link
Copy Markdown

The bug: have a column with a hyphen, like "col-3". Build an index on it. Call list_indices, get a value that's double-quoted, like:

{'name': 'col-3_idx', 'type': 'BTree', 'uuid': '5db8a52c-1398-437a-9d1f-9b2570dd1b19', 'fields': ['`col-3`'], 'version': 3, 'fragment_ids': {0}, 'base_id': None}

The fix: use field_path_minimal to only quote the value if it has a dot or a backtick in it (and therefore needs it - otherwise it's impossible to tell if my_loc.coords.lat is {my_loc: {coords: {lat: ...}}} or {my_loc: {"coords.lat": }}

I think this change is purely cosmetic, because calls like drop_column and update_field_metadata seem to work even when passed

"`col-3`"

So I am fine with either merging this or not (and prettifying it on the UI side e.g. if I display these results)

@github-actions github-actions Bot added A-python Python bindings A-namespace Namespace impls bug Something isn't working labels Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-namespace Namespace impls A-python Python bindings bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant