fix: don't quote column names in list_indices#7503
Open
dantasse wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug: have a column with a hyphen, like "col-3". Build an index on it. Call list_indices, get a value that's double-quoted, like:
The fix: use
field_path_minimalto only quote the value if it has a dot or a backtick in it (and therefore needs it - otherwise it's impossible to tell ifmy_loc.coords.latis{my_loc: {coords: {lat: ...}}}or{my_loc: {"coords.lat": }}I think this change is purely cosmetic, because calls like
drop_columnandupdate_field_metadataseem to work even when passedSo I am fine with either merging this or not (and prettifying it on the UI side e.g. if I display these results)