Skip to content

Fix: Prevent overflow of unsigned options in git2#440

Closed
buddhike wants to merge 1 commit into
libgit2:masterfrom
buddhike:fix/overflow
Closed

Fix: Prevent overflow of unsigned options in git2#440
buddhike wants to merge 1 commit into
libgit2:masterfrom
buddhike:fix/overflow

Conversation

@buddhike

Copy link
Copy Markdown

Closes #439

@carlosmn

carlosmn commented Aug 8, 2018

Copy link
Copy Markdown
Member

Enum types in C are representable with an int, we can't choose to pretend it's an unsigned value. This would just muddy the waters wrt interoperability with the library.

libgit2/libgit2#4680 has fixed this meanwhile by making the enum be conformant to the C89 standard again and master now contains that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants