Fix various build warnings#1414
Merged
Merged
Conversation
This fixes various build warnings on Mac and Windows (64-bit).
Member
|
The wsprintf change looks just fine. Thanks @arrbee! |
phatblat
pushed a commit
to phatblat/libgit2
that referenced
this pull request
Sep 13, 2014
Fix various build warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes various build warnings on Mac and Windows (64-bit).
There are two noteworthy changes, I think.
git_reference__alloc()because the string length is known (which is why the strcpy was safe).winhttp.c:put_uuid_string()I replaced the call towsprintfWwithStringCbPrintfWwhich takes an extra parameter to ensure that the output buffer is not overrun. To be honest, I'm really not sure about this change, but there was a Windows deprecation warning for the old function and this is what MSDN recommended (and a sprintf that's not a snprintf always makes me nervous even though this was being checked beforehand).I also removed some duplicated parameter validation code in
winhttp.c:get_temp_file()and tried to clean up the associated code a bit.