Skip to content

ignore: consider files with a CR in their names#2688

Merged
ethomson merged 1 commit into
masterfrom
cmn/ignore-file-trailing-cr
Nov 5, 2014
Merged

ignore: consider files with a CR in their names#2688
ethomson merged 1 commit into
masterfrom
cmn/ignore-file-trailing-cr

Conversation

@carlosmn

@carlosmn carlosmn commented Nov 5, 2014

Copy link
Copy Markdown
Member

We currently consider CR to start the end of the line, but that means
that we miss cases with CR CR LF which can be used with git to match
files whose names have CR at the end of their names.

The fix from the patch comes from Russell's comment in the issue.

This fixes #2536.

We currently consider CR to start the end of the line, but that means
that we miss cases with CR CR LF which can be used with git to match
files whose names have CR at the end of their names.

The fix from the patch comes from Russell's comment in the issue.

This fixes #2536.
@ethomson

ethomson commented Nov 5, 2014

Copy link
Copy Markdown
Member

This syntax is an abomination.

ethomson added a commit that referenced this pull request Nov 5, 2014
ignore: consider files with a CR in their names
@ethomson ethomson merged commit b4e5432 into master Nov 5, 2014
@nulltoken nulltoken deleted the cmn/ignore-file-trailing-cr branch November 8, 2014 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Carriage returns not honored in gitignore files

2 participants