WinHTTP: support best auth mechanism#4055
Merged
Merged
Conversation
|
Any chance someone can pull in this one soon? It's blocking for users of Gitkraken who have upgraded their TFS servers to 2017. |
For username/password credentials, support NTLM or Basic (in that order of priority). Use the WinHTTP built-in authentication support for both, and maintain a bitfield of the supported mechanisms from the response.
9255589 to
4e4a146
Compare
Member
Author
|
FYI @carlosmn - I rebased this to resolve conflicts. |
|
After fixing of this issue, when we should expect the fixing of following LibGit2Sharp issue: Can anyone please tell me as we are facing issues when using LibGit2Sharp with TFS2015/TFS2017. Thanks! |
Contributor
|
We can try to reduce this and report on its own, but x-ref JuliaLang/julia#22681 we're seeing that after this change an empty username and password now gives a generic GIT_ERROR on Windows, whereas on other platforms (and Windows on prior versions of libgit2) it gives GIT_EAUTH. Is this an expected behavior change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For username/password credentials, support NTLM or Basic (in that order of priority). Use the WinHTTP built-in authentication support for both, and maintain a bitfield of the supported mechanisms from the response.
Fixes #4039