Skip to content

Display dependency statuses (issue #3200)#4290

Closed
0x41111111 wants to merge 1 commit into
libgit2:masterfrom
0x41111111:cmake/display-options
Closed

Display dependency statuses (issue #3200)#4290
0x41111111 wants to merge 1 commit into
libgit2:masterfrom
0x41111111:cmake/display-options

Conversation

@0x41111111

Copy link
Copy Markdown

This PR causes CMake to emit a few lines toward the end of the build script running, telling the user what dependencies will be used during the build process, as well as which variant of a dependency will be used (e.g. SecureTransport vs OpenSSL for HTTPS).

Related to issue #3200.

This commit causes the build script to output a few lines toward the end telling the user what dependencies have been found and will be used in the build process.
@pks-t

pks-t commented Jul 3, 2017

Copy link
Copy Markdown
Member

Hi and thanks for your changes! Just for your information: due to #4282, we're currently keeping most pull requests related to the CMakeLists.txt in hold, as it would result in big merge conflicts otherwise. As soon as #4282 is merged, I will come back to you and review your changes.

@tiennou

tiennou commented Jul 10, 2017

Copy link
Copy Markdown
Contributor

For the record, CMake has a module that does something akin to what we want.

@pks-t

pks-t commented Jul 21, 2017

Copy link
Copy Markdown
Member

@tiennou Oh, that looks interesting. Looks like that should be our way forward instead. Thanks for the hint!

@carlosmn

carlosmn commented Nov 4, 2017

Copy link
Copy Markdown
Member

This CMake module would be available in any installation? I would definitely much prefer an implementation which uses that.

@tiennou

tiennou commented Nov 5, 2017

Copy link
Copy Markdown
Contributor

I added that to #4283 actually. Seems the interface varies by CMake version, but is somewhat available.

@pks-t

pks-t commented Nov 6, 2017

Copy link
Copy Markdown
Member

I'd also say just go with that and simply ignore all older CMake versions which do not support that module.

@pks-t

pks-t commented Nov 30, 2017

Copy link
Copy Markdown
Member

This has already been implemented via #4283

@pks-t pks-t closed this Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants