WIP: travis: fail on memory leaks#4416
Closed
ethomson wants to merge 1 commit into
Closed
Conversation
Pass `--error-exitcode=125` to valgrind so that it will exit with a non-zero exit code when it detects a memory leak. Use an exit code of `125` to stay safely above any clar errors and safely below any shell errors.
Member
|
We'll have to migrate the Valgrind execution out of
|
Merged
Member
|
I'm closing this in favour of #4558 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
--error-exitcode=125to valgrind so that it will exit with a non-zero exit code when it detects a memory leak. Use an exit code of125to stay safely above any clar errors and safely below any shell errors.Note: I suspect that there are some tests that we'll need to either exclude from valgrind's examination, or perhaps not run at all.