sha1: don't inline git_hash_global_init for win32#5039
Merged
Conversation
Users of the Win32 hash cannot be inlined, as it uses a static struct. Don't inline it, but continue to declare the function in the header.
pks-t
approved these changes
Apr 5, 2019
pks-t
left a comment
Member
There was a problem hiding this comment.
👍 This is basically the same thing I do in my multi-hash PR.
Member
|
Waiting for @csware to confirm it fixes his problem. |
Member
|
By the way, we could also just go all the way and merge #4438, as it also moves all hash implementations into their respective C files. |
Contributor
|
Works. |
Member
Author
Aha, sorry. I thought that #4438 was sort of holding until we were going to add additional hashes. I'm going to go ahead and merge this to unblock @csware but I agree that we should give that some more consideration in the near term. |
Member
|
On Sun, Apr 07, 2019 at 03:10:17AM -0700, Edward Thomson wrote:
> By the way, we could also just go all the way and merge
> #4438, as it also moves all hash implementations into their
> respective C files.
Aha, sorry. I thought that #4438 was sort of holding until we
were going to add additional hashes. I'm going to go ahead and
merge this to unblock @csware but I agree that we should give
that some more consideration in the near term.
Sorry for not making this clearer. I do intend to get this merged
as soon as possible to allow adding additional hashes and get
started the work towards SHA256. My plan was to create smallish
chunks that are rather uncontroversial and not too burdensome to
review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users of the Win32 hash cannot be inlined, as it uses a static struct.
Don't inline it, but continue to declare the function in the header.
/cc @csware