Sorry for the extra noise, but I force-pushed to my branch to fix up the documentation I wrote (https proxies are not supported by libgit2), but the PR didn't update ... not sure what that's about.

@carlosmn, not sure if you're the right person to ping here, but could you take a look at this?

Thanks!

Would be great if this 🚢'd! We're using environment variable in the meantime.

@carlosmn We could really use this PR merged if you could review.

Could we get some 👀 on this one? It would be great to have this merged! ❤️

I'm also interested in seeing this go in, hoping to pick it up for use in r10k. We've been having trouble getting proxies working right since the libgit2 update dropping curl, and I think this might be the missing link for us, that's cleaner than what we used to do anyway.

also cc @pks-t

The behavior we were using before in r10k relied on libcurl checking environment variables for proxies by default. The new implementation in libgit no longer does this; instead you have to configure fetch_opts.proxy_opts.type = GIT_PROXY_AUTO.

We can probably use what this PR adds with some changes to our proxy handling, but I was curious if anyone else wanted to use environment variables to configure proxies? If so, it might be worth also adding that option. I might look into it, especially if this route doesn't wind up being feasible for us.

Looks good thanks. Potentially we could see an :auto value in order to set to the _AUTO but that can be part of some later change.