Delegate equals comparison in Record to Field - #1976
Merged
Conversation
farmdawgnation
approved these changes
Nov 26, 2019
farmdawgnation
left a comment
Member
There was a problem hiding this comment.
LGTM overall, and I'm pretty sure this is backward compatible.
| /** | ||
| * Pattern.equals doesn't work properly so it needs a special check. If you use PatternField, be sure to override equals with this. | ||
| */ | ||
| @deprecated("PatternField now has a properly functioning `equals` method.", "3.4.0") |
Member
There was a problem hiding this comment.
Suggested change
| @deprecated("PatternField now has a properly functioning `equals` method.", "3.4.0") | |
| @deprecated("PatternField now has a properly functioning `equals` method.", "3.4.1") |
Member
Author
|
Uh, I just noticed that commit suggestion button. I haven't used that yet. Looks really handy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1975