feat(lift-markdown)!: cross compile for scala 3 - #2034
Merged
Conversation
- rename `inline` to `inlineParser` to avoid the keyword collision - fix indentation - change postfix `*` to `.*` - removed junit specific bits b/c tests run fine without them
farmdawgnation
force-pushed
the
msf/lift-markdown-scala3
branch
from
August 21, 2025 01:07
0835175 to
359c1a6
Compare
farmdawgnation
marked this pull request as ready for review
August 21, 2025 01:16
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Lift markdown module to support cross-compilation for Scala 3 by addressing keyword conflicts and syntax changes.
- Renames
inlinemethod toinlineParserto avoid Scala 3 keyword collision - Updates postfix
*operators to use.*syntax for Scala 3 compatibility - Removes JUnit-specific test annotations and imports
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| TransformerTest.scala | Removes JUnit runner imports and annotations |
| LineTokenizerTest.scala | Removes JUnit runner imports and annotations |
| LineParsersTest.scala | Removes JUnit runner imports and annotations |
| InlineParsersTest.scala | Removes JUnit imports/annotations and updates inline calls to inlineParser |
| BlockParsersTest.scala | Removes JUnit runner imports and annotations |
| BaseParsersTest.scala | Removes JUnit runner imports and annotations |
| LineTokenizer.scala | Updates postfix * to .* syntax |
| InlineParsers.scala | Renames inline method to inlineParser and updates usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inlinetoinlineParserto avoid the keyword collision*to.*