Skip to content

Remove constants.php - #62

Closed
alex-phillips wants to merge 1 commit into
masterfrom
remove-constants
Closed

Remove constants.php#62
alex-phillips wants to merge 1 commit into
masterfrom
remove-constants

Conversation

@alex-phillips

@alex-phillips alex-phillips commented Feb 29, 2024

Copy link
Copy Markdown
Member

new versions no longer use the Constants.php files as these values are now read and stored into the database

linuxserver.io

  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Benefits of this PR and context:

How Has This Been Tested?

Source / References:

@LinuxServer-CI

LinuxServer-CI commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-d64b446c-dev-8029917340de70064ae8aac62fc166f202440ef8-pr-62/index.html
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-d64b446c-dev-8029917340de70064ae8aac62fc166f202440ef8-pr-62/shellcheck-result.xml

Tag Passed
amd64-v2.2.2-pkg-d64b446c-dev-8029917340de70064ae8aac62fc166f202440ef8-pr-62 ✅
arm64v8-v2.2.2-pkg-d64b446c-dev-8029917340de70064ae8aac62fc166f202440ef8-pr-62 ✅

@LinuxServer-CI

LinuxServer-CI commented Mar 29, 2024

Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-4f1baa33-dev-f465f31116f3fd551791d6a2260fc7a8f28126fb-pr-62/index.html
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-4f1baa33-dev-f465f31116f3fd551791d6a2260fc7a8f28126fb-pr-62/shellcheck-result.xml

Tag Passed
amd64-v2.2.2-pkg-4f1baa33-dev-f465f31116f3fd551791d6a2260fc7a8f28126fb-pr-62 ✅
arm64v8-v2.2.2-pkg-4f1baa33-dev-f465f31116f3fd551791d6a2260fc7a8f28126fb-pr-62 ✅

@LinuxServer-CI

LinuxServer-CI commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-9d5108f4-dev-7b9eee031d0bcc449667f7e4eee8bba850edae3a-pr-62/index.html
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-9d5108f4-dev-7b9eee031d0bcc449667f7e4eee8bba850edae3a-pr-62/shellcheck-result.xml

Tag Passed
amd64-v2.2.2-pkg-9d5108f4-dev-7b9eee031d0bcc449667f7e4eee8bba850edae3a-pr-62 ✅
arm64v8-v2.2.2-pkg-9d5108f4-dev-7b9eee031d0bcc449667f7e4eee8bba850edae3a-pr-62 ✅

@LinuxServer-CI

LinuxServer-CI commented May 23, 2024

Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-ba398fad-dev-e6c67bc91fc10edbdcdef874999cc82bd4530f2e-pr-62/index.html
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-ba398fad-dev-e6c67bc91fc10edbdcdef874999cc82bd4530f2e-pr-62/shellcheck-result.xml

Tag Passed
amd64-v2.2.2-pkg-ba398fad-dev-e6c67bc91fc10edbdcdef874999cc82bd4530f2e-pr-62 ✅
arm64v8-v2.2.2-pkg-ba398fad-dev-e6c67bc91fc10edbdcdef874999cc82bd4530f2e-pr-62 ✅

@LinuxServer-CI

LinuxServer-CI commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-2b366d47-dev-d0813a884d933a04a096eeec126bec416dd97074-pr-62/index.html
https://ci-tests.linuxserver.io/lspipepr/diskover/v2.2.2-pkg-2b366d47-dev-d0813a884d933a04a096eeec126bec416dd97074-pr-62/shellcheck-result.xml

Tag Passed
amd64-v2.2.2-pkg-2b366d47-dev-d0813a884d933a04a096eeec126bec416dd97074-pr-62 ✅
arm64v8-v2.2.2-pkg-2b366d47-dev-d0813a884d933a04a096eeec126bec416dd97074-pr-62 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

Issue & PR Tracker
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alex-phillips @LinuxServer-CI