Skip to content

Switch IGN France to HIGHRES (RGE ALTI) WMS layer#1027

Merged
louis-e merged 1 commit into
mainfrom
fix/ign-france-hires-layer
May 14, 2026
Merged

Switch IGN France to HIGHRES (RGE ALTI) WMS layer#1027
louis-e merged 1 commit into
mainfrom
fix/ign-france-hires-layer

Conversation

@louis-e

@louis-e louis-e commented May 14, 2026

Copy link
Copy Markdown
Owner

The previous LAYERS=ELEVATION.ELEVATIONGRIDCOVERAGE is BD ALTI v1, capped at the WMTS z11 pyramid (~25 m EW x 38 m NS at lat 48). The WMS server nearest-neighbour-upsamples that to the requested 512x512 tile, producing 38x25-block flat patches with 2-3 m steps between them in the generated terrain.

ELEVATION.ELEVATIONGRIDCOVERAGE.HIGHRES is RGE ALTI MNT served from the z14 pyramid (~3 m EW x 5 m NS), 7-8x finer. Verified at the reporter's bbox: 14 -> 108 source runs per row, plateaus shrink from ~37 px to ~5 px wide.

CACHE_NAME bumped to ign_france_hires to invalidate the legacy plateau-quantised tiles on disk; name() is overridden so the user-visible "Selected elevation provider" log stays "ign_france".

The previous LAYERS=ELEVATION.ELEVATIONGRIDCOVERAGE is BD ALTI v1,
capped at the WMTS z11 pyramid (~25 m EW x 38 m NS at lat 48). The
WMS server nearest-neighbour-upsamples that to the requested 512x512
tile, producing 38x25-block flat patches with 2-3 m steps between
them in the generated terrain.

ELEVATION.ELEVATIONGRIDCOVERAGE.HIGHRES is RGE ALTI MNT served from
the z14 pyramid (~3 m EW x 5 m NS), 7-8x finer. Verified at the
reporter's bbox: 14 -> 108 source runs per row, plateaus shrink from
~37 px to ~5 px wide.

CACHE_NAME bumped to ign_france_hires to invalidate the legacy
plateau-quantised tiles on disk; name() is overridden so the
user-visible "Selected elevation provider" log stays "ign_france".
Copilot AI review requested due to automatic review settings May 14, 2026 22:55
@github-actions

Copy link
Copy Markdown

⏱️ Benchmark run finished in 0m 54s
🏗️ Generation time: 28s (excl. data fetching)
🧠 Peak memory usage: 873 MB (↘ 6% less)

📈 Compared against baseline: 27s time, 935 MB memory
🧮 Delta: 27s time, -62 MB memory
🔢 Commit: 36090bb

🟢 Generation time is unchanged.
🌱 This PR reduces peak memory.

📅 Last benchmark: 2026-05-14 22:57:52 UTC

You can retrigger the benchmark by commenting retrigger-benchmark.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the IGN France elevation provider to request the higher-resolution RGE ALTI MNT WMS layer (HIGHRES) instead of the legacy BD ALTI v1 layer, improving source detail and reducing visible “plateau banding” artifacts in generated terrain.

Changes:

  • Switches the WMS LAYERS parameter to ELEVATION.ELEVATIONGRIDCOVERAGE.HIGHRES.
  • Bumps the on-disk cache namespace (CACHE_NAME) to invalidate previously cached lower-resolution tiles.
  • Keeps the user-facing provider id stable by returning "ign_france" from ElevationProvider::name().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/elevation/providers/ign_france.rs
@louis-e louis-e merged commit 1059da9 into main May 14, 2026
7 checks passed
@louis-e louis-e deleted the fix/ign-france-hires-layer branch May 14, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants