Implement more realistic elevation#702
Conversation
|
⏱️ Benchmark run finished in 0m 38s 📈 Compared against baseline: 30s 📅 Last benchmark: 2026-01-08 22:04:19 UTC You can retrigger the benchmark by commenting |
There was a problem hiding this comment.
Pull request overview
This PR implements more realistic elevation mapping by changing from a heavily scaled/compressed elevation model to a 1:1 (or scale-factor:1) mapping of real-world elevation to Minecraft blocks. The old system used a BASE_HEIGHT_SCALE constant and aggressive compression; the new system only compresses terrain when it would exceed Minecraft's build height limit.
Key changes:
- Removed BASE_HEIGHT_SCALE constant and replaced with scale-based realistic elevation mapping
- Added valley bridge detection that uses fixed deck heights to span valleys without dipping
- Introduced absolute Y coordinate placement methods for bridges to avoid terrain-following behavior
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/elevation_data.rs | Removed BASE_HEIGHT_SCALE constant and implemented realistic 1:1 elevation scaling with conditional compression only when terrain exceeds build limits |
| src/world_editor/mod.rs | Added get_ground_level method to query terrain elevation at specific coordinates without offsets |
| src/element_processing/highways.rs | Implemented valley bridge detection with terrain sampling, added absolute Y coordinate placement for bridges with level decks, and created separate pillar generation for bridges |
| src/element_processing/buildings.rs | Updated bridge generation to use max endpoint elevation for level bridge decks instead of terrain-following placement |
| src/element_processing/bridges.rs | Modified bridge generation to use absolute Y coordinates and improved ramp calculations based on overall bridge progress |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
retrigger-benchmark |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
retrigger-benchmark |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
retrigger-benchmark |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
retrigger-benchmark |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
retrigger-benchmark |
|
retrigger-benchmark |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Slower benchmark due to first API call failing. So unrelated to our changes |
Uh oh!
There was an error while loading. Please reload this page.